Page MenuHomePhabricator
Differential D14263

Fix errors when mentioning others in Ponder
ClosedPublic
Actions

Authored by chad on Oct 13 2015, 4:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 3:45 AM
Unknown Object (File)
Wed, Feb 12, 10:29 AM
Unknown Object (File)
Wed, Feb 12, 10:29 AM
Unknown Object (File)
Wed, Feb 12, 10:16 AM
Unknown Object (File)
Mon, Feb 10, 9:29 AM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
Unknown Object (File)
Sat, Feb 8, 11:31 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9552: Users cannot answer questions on Ponder
Commits
Restricted Diffusion Commit
rP6ff1354ac1ff: Fix errors when mentioning others in Ponder
Summary

Fixes T9552. We need to set a questionID and the question object (for policy) when initializing a new Answer.

Test Plan

Write an answer that mentions another user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34436.Oct 13 2015, 4:15 AM
chad retitled this revision from to Fix errors when mentioning others in Ponder.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 13 2015, 4:15 AM
chad added inline comments.Oct 13 2015, 4:17 AM
src/applications/ponder/storage/PonderAnswer.php
38

See T9552. I need to do policy checks, which need the question attached, not sure how to attach it during 'New Answer' initialization since its a static method.

epriestley added inline comments.Oct 13 2015, 10:07 AM
src/applications/ponder/storage/PonderAnswer.php
38

You can attach it like this, here:

   ...
   ->setQuestionID(...)
+  ->attachQuestion($question)
   ->setContent(...)
   ...
chad updated this revision to Diff 34440.Oct 13 2015, 4:08 PM
  • Updates
chad updated this object.Oct 13 2015, 4:08 PM
chad added a task: T9552: Users cannot answer questions on Ponder.
epriestley accepted this revision.Oct 13 2015, 4:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2015, 4:08 PM
Closed by commit rP6ff1354ac1ff: Fix errors when mentioning others in Ponder (authored by chad, committed by chad). · Explain WhyOct 13 2015, 4:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
ponder/
controller/
2 lines
storage/
7 lines

Diff 34441

View Options

src/applications/ponder/controller/PonderAnswerSaveController.php

Loading...
View Options

src/applications/ponder/storage/PonderAnswer.php

Loading...
Phabricator · Built by Phacility