Page MenuHomePhabricator

In Harbormaster, make sure artifacts are destroyed even if a build is aborted
ClosedPublic

Authored by epriestley on Oct 4 2015, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 9:17 PM
Unknown Object (File)
Wed, Mar 20, 10:37 PM
Unknown Object (File)
Mon, Mar 18, 10:18 PM
Unknown Object (File)
Sat, Mar 16, 7:14 PM
Unknown Object (File)
Wed, Mar 13, 10:18 PM
Unknown Object (File)
Mon, Mar 4, 6:32 PM
Unknown Object (File)
Mon, Mar 4, 6:32 PM
Unknown Object (File)
Feb 19 2024, 5:50 PM
Subscribers
None

Details

Summary

Ref T9252. Currently, Harbormaster and Drydock work like this in some cases:

  1. Queue a lease for activation.
  2. Then, a little later, save the lease PHID somewhere.
  3. When the target/resource is destroyed, destroy the lease.

However, something can happen between (1) and (2). In Drydock this window is very short and the "something" would have to be a lighting strike or something similar, but in Harbormaster we wait until the resource activates to do (2) so the window can be many minutes long. In particular, a user can use "Abort Build" during those many minutes.

If they do, the target is destroyed but it doesn't yet have a record of the artifact, so the artifact isn't cleaned up.

Make these things work like this instead:

  1. Create a new lease and pre-generate a PHID for it.
  2. Save that PHID as something that needs to be cleaned up.
  3. Queue the lease for activation.
  4. When the target/resource is destroyed, destroy the lease if it exists.

This makes sure there's no step in the process where we might lose track of a lease/resource.

Also, clean up and standardize some other stuff I hit.

Test Plan
  • Stopped daemons.
  • Restarted a build in Harbormaster.
  • Stepped through the build one stage at a time using bin/worker execute ....
  • After the lease was queued, but before it activated, aborted the build.
  • Processed the Harbormaster side of things only.
  • Saw the lease get destroyed properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to In Harbormaster, make sure artifacts are destroyed even if a build is aborted.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
hach-que edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 12:30 AM
This revision was automatically updated to reflect the committed changes.