Page MenuHomePhabricator

Improve Diffusion behavior for no-longer-existing commits
ClosedPublic

Authored by epriestley on Oct 2 2015, 11:04 PM.
Tags
None
Referenced Files
F15436767: D14227.diff
Tue, Mar 25, 4:31 PM
F15435387: D14227.diff
Tue, Mar 25, 8:01 AM
F15290882: D14227.id34356.diff
Tue, Mar 4, 11:54 PM
Unknown Object (File)
Sun, Feb 23, 11:01 PM
Unknown Object (File)
Feb 23 2025, 3:09 AM
Unknown Object (File)
Feb 14 2025, 3:44 AM
Unknown Object (File)
Feb 13 2025, 12:45 AM
Unknown Object (File)
Feb 12 2025, 12:06 AM
Subscribers
None

Details

Summary

Ref T9028. When users push a commit, then later delete it (e.g., by deleting the branch which contained it) we currently explode when trying to view it.

Instead, degrade gradually if some information is not available.

Test Plan
  • Looked at valid commits with parents, refs, branches and merges.
  • Looked at invalid commits.
  • Looked at a previously valid, now-deleted + gc'd commit:

Screen Shot 2015-10-02 at 4.01.27 PM.png (1×1 px, 219 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve Diffusion behavior for no-longer-existing commits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 11:09 PM
This revision was automatically updated to reflect the committed changes.