Page MenuHomePhabricator
Differential D14227

Improve Diffusion behavior for no-longer-existing commits
ClosedPublic
Actions

Authored by epriestley on Oct 2 2015, 11:04 PM.
Tags
None
Referenced Files
F18953019: D14227.diff
Wed, Nov 12, 6:54 AM
F18952809: D14227.diff
Wed, Nov 12, 6:33 AM
F18856021: D14227.diff
Sat, Nov 1, 7:37 AM
F18855449: D14227.id.diff
Sat, Nov 1, 5:18 AM
F18853027: D14227.id34355.diff
Fri, Oct 31, 1:50 PM
F18829879: D14227.id34356.diff
Oct 25 2025, 1:51 AM
F18806404: D14227.id.diff
Oct 18 2025, 7:18 PM
F18780632: D14227.id.diff
Oct 12 2025, 6:07 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9028: Phabricator handles commits which are published and later deleted poorly
Commits
Restricted Diffusion Commit
rPf760b3ec98cd: (stable) Promote 2015 Week 40
rP0db86cce7df7: Improve Diffusion behavior for no-longer-existing commits
Summary

Ref T9028. When users push a commit, then later delete it (e.g., by deleting the branch which contained it) we currently explode when trying to view it.

Instead, degrade gradually if some information is not available.

Test Plan
  • Looked at valid commits with parents, refs, branches and merges.
  • Looked at invalid commits.
  • Looked at a previously valid, now-deleted + gc'd commit:

Screen Shot 2015-10-02 at 4.01.27 PM.png (1×1 px, 219 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34355.Oct 2 2015, 11:04 PM
epriestley retitled this revision from to Improve Diffusion behavior for no-longer-existing commits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9028: Phabricator handles commits which are published and later deleted poorly.
epriestley mentioned this in T9028: Phabricator handles commits which are published and later deleted poorly.Oct 2 2015, 11:06 PM
chad accepted this revision.Oct 2 2015, 11:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 11:09 PM
Closed by commit rP0db86cce7df7: Improve Diffusion behavior for no-longer-existing commits (authored by epriestley, committed by epriestley). · Explain WhyOct 2 2015, 11:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
277 lines

Diff 34356

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
Phabricator · Built by Phacility