Page MenuHomePhabricator

Provide `bin/garbage` for interacting with garbage collection
ClosedPublic

Authored by epriestley on Oct 1 2015, 11:17 PM.
Tags
None
Referenced Files
F13088350: D14219.diff
Thu, Apr 25, 1:24 AM
Unknown Object (File)
Fri, Apr 19, 3:41 PM
Unknown Object (File)
Sat, Apr 6, 5:10 PM
Unknown Object (File)
Fri, Apr 5, 10:23 PM
Unknown Object (File)
Mon, Apr 1, 2:20 AM
Unknown Object (File)
Fri, Mar 29, 7:01 PM
Unknown Object (File)
Thu, Mar 28, 8:05 PM
Unknown Object (File)
Mar 17 2024, 8:40 PM
Subscribers
None

Details

Summary

Fixes T9494. This:

  • Removes all the random GC.x.y.z config.
  • Puts it all in one place that's locked and which you use bin/garbage set-policy ... to adjust.
  • Makes every TTL-based GC configurable.
  • Simplifies the code in the actual GCs.
Test Plan
  • Ran bin/garbage collect to collect some garbage, until it stopped collecting.
  • Ran bin/garbage set-policy ... to shorten policy. Saw change in web UI. Ran bin/garbage collect again and saw it collect more garbage.
  • Set policy to indefinite and saw it not collect garabge.
  • Set policy to default and saw it reflected in web UI / collect.
  • Ran bin/phd debug trigger and saw all GCs fire with reasonable looking queries.
  • Read new docs.

Screen Shot 2015-10-01 at 4.16.42 PM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide `bin/garbage` for interacting with garbage collection.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 2:02 PM
This revision was automatically updated to reflect the committed changes.