Page MenuHomePhabricator

Merge the DrydockLease workers into a single worker
ClosedPublic

Authored by epriestley on Sep 30 2015, 9:42 PM.
Tags
None
Referenced Files
F15463146: D14202.diff
Tue, Apr 1, 8:43 PM
F15458271: D14202.id34301.diff
Sun, Mar 30, 10:26 PM
F15455137: D14202.diff
Sat, Mar 29, 10:29 PM
F15427507: D14202.id34319.diff
Sun, Mar 23, 2:44 PM
F15426815: D14202.id.diff
Sun, Mar 23, 10:55 AM
F15373442: D14202.diff
Mar 12 2025, 4:07 PM
F15337093: D14202.diff
Mar 9 2025, 4:03 AM
F15335267: D14202.diff
Mar 8 2025, 2:52 PM
Subscribers
None

Details

Summary

Ref T9252. This is the same as D14201, but for lease stuff instead of resource stuff.

This one is a little heavier but still feels pretty reasonable to me at the end of the day (worker is <1K lines and has a ton of comment stuff).

Also fixes a few random bugs I hit in the task queue.

Test Plan
  • Restarted some Harbormaster builds, saw them go through cleanly.
  • Released pre-activation resources/leases.
  • Probably still kinda buggy but I'll iron the details out over time.

Logs are starting to look somewhat plausible:

Screen Shot 2015-09-30 at 2.31.54 PM.png (1×1 px, 269 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Merge the DrydockLease workers into a single worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 10:53 PM
This revision was automatically updated to reflect the committed changes.