Page MenuHomePhabricator

Merge the DrydockLease workers into a single worker
ClosedPublic

Authored by epriestley on Sep 30 2015, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 6:27 PM
Unknown Object (File)
Mon, Mar 4, 6:18 PM
Unknown Object (File)
Mon, Mar 4, 6:18 PM
Unknown Object (File)
Feb 20 2024, 3:55 AM
Unknown Object (File)
Feb 16 2024, 8:25 PM
Unknown Object (File)
Feb 14 2024, 5:24 AM
Unknown Object (File)
Feb 10 2024, 6:29 PM
Unknown Object (File)
Feb 10 2024, 4:09 PM
Subscribers
None

Details

Summary

Ref T9252. This is the same as D14201, but for lease stuff instead of resource stuff.

This one is a little heavier but still feels pretty reasonable to me at the end of the day (worker is <1K lines and has a ton of comment stuff).

Also fixes a few random bugs I hit in the task queue.

Test Plan
  • Restarted some Harbormaster builds, saw them go through cleanly.
  • Released pre-activation resources/leases.
  • Probably still kinda buggy but I'll iron the details out over time.

Logs are starting to look somewhat plausible:

Screen Shot 2015-09-30 at 2.31.54 PM.png (1×1 px, 269 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Merge the DrydockLease workers into a single worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 10:53 PM
This revision was automatically updated to reflect the committed changes.