Page MenuHomePhabricator

Merge the DrydockLease workers into a single worker
ClosedPublic

Authored by epriestley on Sep 30 2015, 9:42 PM.
Tags
None
Referenced Files
F19099570: D14202.id34319.diff
Dec 4 2025, 8:39 PM
F19043388: D14202.id.diff
Nov 26 2025, 9:53 PM
F19033582: D14202.diff
Nov 25 2025, 11:09 AM
F18832403: D14202.id.diff
Oct 25 2025, 9:43 PM
F18827699: D14202.diff
Oct 24 2025, 11:34 AM
F18810522: D14202.id.diff
Oct 19 2025, 10:01 PM
F18751792: D14202.diff
Oct 4 2025, 12:40 PM
F18623150: D14202.id34319.diff
Sep 15 2025, 2:32 PM
Subscribers
None

Details

Summary

Ref T9252. This is the same as D14201, but for lease stuff instead of resource stuff.

This one is a little heavier but still feels pretty reasonable to me at the end of the day (worker is <1K lines and has a ton of comment stuff).

Also fixes a few random bugs I hit in the task queue.

Test Plan
  • Restarted some Harbormaster builds, saw them go through cleanly.
  • Released pre-activation resources/leases.
  • Probably still kinda buggy but I'll iron the details out over time.

Logs are starting to look somewhat plausible:

Screen Shot 2015-09-30 at 2.31.54 PM.png (1×1 px, 269 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Merge the DrydockLease workers into a single worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 10:53 PM
This revision was automatically updated to reflect the committed changes.