Differential D14200

Allow 201 status code as a response for harbormaster build plans.
Needs RevisionPublic
Actions

Authored by • ybv on Sep 30 2015, 7:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Allow 201 status code as a response for harbormaster build plans.

Test Plan

None.

Diff Detail

Repository

rP Phabricator

Branch

allow-201-hm

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 8106
Build 9238: [Placeholder Plan] Wait for 30 Seconds
Build 9237: arc lint + arc unit

Event Timeline

• ybv updated this revision to Diff 34298.Sep 30 2015, 7:38 PM

• ybv retitled this revision from to Allow 201 status code as a response for harbormaster build plans..

• ybv updated this object.

• ybv edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 30 2015, 7:38 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

• ybv mentioned this in T9478: Working with harbormaster.sendmessage.Sep 30 2015, 7:39 PM

eadler added a subscriber: eadler.Oct 14 2015, 6:02 AM

eadler added inline comments.

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php
92	why not allow 2xx in general?

Obsolete in HEAD.

This revision now requires changes to proceed.Nov 2 2015, 4:44 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterHTTPRequestBuildStepImplementation.php

2 lines

Diff 34298

View Options

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Allow 201 status code as a response for harbormaster build plans.Needs RevisionPublicActions