Paths

Table of Contentst

Differential D14194

Reset Drydock git working copies better
ClosedPublic
Actions

Authored by epriestley on Sep 30 2015, 1:26 PM.

Tags

None

Referenced Files

	F13087662: D14194.diff
	Thu, Apr 25, 1:02 AM

	Unknown Object (File)
	Sat, Apr 20, 2:12 AM

	Unknown Object (File)
	Fri, Apr 19, 3:40 PM

	Unknown Object (File)
	Fri, Apr 12, 5:32 PM

	Unknown Object (File)
	Tue, Apr 2, 5:09 PM

	Unknown Object (File)
	Tue, Apr 2, 5:08 PM

	Unknown Object (File)
	Mar 10 2024, 11:11 AM

	Unknown Object (File)
	Mar 7 2024, 11:00 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9252: Unprototype Drydock (v1)

Commits

Restricted Diffusion Commit
rP9d997df9643b: Reset Drydock git working copies better

Summary

Ref T9252. We're currently resetting to the local branch, but should be resetting to the origin branch.

Test Plan

Restarted a build, had it run git show, saw proper HEAD.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34289.Sep 30 2015, 1:26 PM

epriestley retitled this revision from to Reset Drydock git working copies better.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9252: Unprototype Drydock (v1).

chad accepted this revision.Sep 30 2015, 1:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 30 2015, 1:42 PM

hach-que added a subscriber: hach-que.Sep 30 2015, 2:04 PM

hach-que added inline comments.

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php
206	This should `git clean -x -d --force --force` as discussed elsewhere.

In the Phabricator case, at least, we don't want to -x. If we -x, we remove the phutil library cache, which is otherwise robust and well-behaved, and our build times rise from about 12s to about 600s.

I think "how slowly/thoroughly should the working copy be cleaned" will probably end up as an option on the WorkingCopy blueprint, but for now I'm just hard-coding the most useful behavior for upstream builds.

Closed by commit rP9d997df9643b: Reset Drydock git working copies better (authored by epriestley, committed by epriestley). · Explain WhySep 30 2015, 2:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockWorkingCopyBlueprintImplementation.php

5 lines

Diff 34293

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...