Hide "Revision" column in Diffusion history view if Differential is uninstalled
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 1:22 PM.

Details

Reviewers

Maniphest Tasks

T9481: Allow 'revision' section in history to be hidden when differential is uninstalled

Commits

Restricted Diffusion Commit
rP6d5c9e897d31: Hide "Revision" column in Diffusion history view if Differential is uninstalled

Summary

Fixes T9481. If the viewer does not have access to Differential (for example, because it is not installed), hide the "Revision" column in Diffusion.

Test Plan

Viewed history, saw "Revision" column.
Uninstalled Differential, reloaded, no "Revision" column.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34274.Sep 29 2015, 1:22 PM

epriestley retitled this revision from to Hide "Revision" column in Diffusion history view if Differential is uninstalled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9481: Allow 'revision' section in history to be hidden when differential is uninstalled.

revi added a subscriber: revi.Sep 29 2015, 1:23 PM

chad accepted this revision.Sep 29 2015, 1:48 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2015, 1:48 PM

Closed by commit rP6d5c9e897d31: Hide "Revision" column in Diffusion history view if Differential is uninstalled (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionHistoryTableView.php

9 lines

Diff 34278

View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Hide "Revision" column in Diffusion history view if Differential is uninstalledClosedPublicActions