Page MenuHomePhabricator

Allow users to skip "arc:prompt" by entering no text
ClosedPublic

Authored by epriestley on Sep 29 2015, 11:45 AM.
Tags
None
Referenced Files
F18191734: D14187.id34273.diff
Sun, Aug 17, 3:04 AM
F18085229: D14187.diff
Tue, Aug 5, 7:04 PM
F17856006: D14187.id34273.diff
Jul 27 2025, 4:48 PM
F17849514: D14187.id34279.diff
Jul 27 2025, 8:47 AM
F17848656: D14187.id.diff
Jul 27 2025, 7:39 AM
F17840320: D14187.diff
Jul 26 2025, 9:01 PM
Unknown Object (File)
May 25 2025, 9:38 AM
Unknown Object (File)
May 10 2025, 1:31 PM
Subscribers
None

Details

Summary

Fixes T9476. Currently, if you enter no text in "arc:prompt", we abort resolution immediately.

However, this is a bit inconsistent (other rules that fail to resolve are skipped) it is reasonable to put some default rule behind "arc:prompt" so that you can just mash enter to select it. This construction is unusual, but seems fine and sensible to me.

If you're using "arc:prompt" as the last rule, the behavior is the same as before, so this should only make the rule more useful.

Test Plan
  • Ran arc which --base 'arc:prompt, git:HEAD^' with and without the patch.
  • Without the patch, entering no text at "arc:prompt" failed immediately.
  • With the patch, entering no text caused fallback to the "git:HEAD^" rule.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow users to skip "arc:prompt" by entering no text.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 2:02 PM
This revision was automatically updated to reflect the committed changes.