Page MenuHomePhabricator

Allow users to skip "arc:prompt" by entering no text
ClosedPublic

Authored by epriestley on Sep 29 2015, 11:45 AM.
Tags
None
Referenced Files
F19514146: D14187.id34273.diff
Tue, Jan 13, 10:41 PM
F19495117: D14187.id34273.diff
Thu, Jan 8, 10:14 AM
F19102268: D14187.diff
Dec 5 2025, 6:17 AM
F18927542: D14187.diff
Nov 9 2025, 9:06 PM
F18873753: D14187.id.diff
Nov 5 2025, 11:20 AM
F18868380: D14187.diff
Nov 4 2025, 6:19 AM
F18740471: D14187.id34279.diff
Oct 2 2025, 3:23 AM
F18737511: D14187.id.diff
Oct 1 2025, 11:11 AM
Subscribers
None

Details

Summary

Fixes T9476. Currently, if you enter no text in "arc:prompt", we abort resolution immediately.

However, this is a bit inconsistent (other rules that fail to resolve are skipped) it is reasonable to put some default rule behind "arc:prompt" so that you can just mash enter to select it. This construction is unusual, but seems fine and sensible to me.

If you're using "arc:prompt" as the last rule, the behavior is the same as before, so this should only make the rule more useful.

Test Plan
  • Ran arc which --base 'arc:prompt, git:HEAD^' with and without the patch.
  • Without the patch, entering no text at "arc:prompt" failed immediately.
  • With the patch, entering no text caused fallback to the "git:HEAD^" rule.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow users to skip "arc:prompt" by entering no text.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2015, 2:02 PM
This revision was automatically updated to reflect the committed changes.