Page MenuHomePhabricator

Allow WorkingCopy resources to have multiple working copies
ClosedPublic

Authored by epriestley on Sep 28 2015, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 4:51 PM
Unknown Object (File)
Sun, Mar 10, 3:01 PM
Unknown Object (File)
Sun, Mar 10, 2:50 PM
Unknown Object (File)
Sun, Mar 10, 2:46 PM
Unknown Object (File)
Sun, Mar 10, 10:35 AM
Unknown Object (File)
Sun, Mar 10, 8:57 AM
Unknown Object (File)
Thu, Mar 7, 10:41 AM
Unknown Object (File)
Mon, Mar 4, 6:17 PM
Subscribers
None

Details

Summary

Ref T9252. For building Phabricator itself, we need to have libphutil/, arcanist/ and phabricator/ next to one another on disk.

Expand the Drydock WorkingCopy resource so that it can have multiple repositories if the caller needs them.

I'm not sure if I'm going to put the actual config for this in Harbormaster or Drydock yet, but the WorkingCopy resource itself should work the same way in either case.

Test Plan

Restarted a Harbormaster build which leases a working copy, saw it build as expected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow WorkingCopy resources to have multiple working copies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2015, 4:26 PM
This revision was automatically updated to reflect the committed changes.