Page MenuHomePhabricator

Make some Herald errors more spider-resistant
ClosedPublic

Authored by epriestley on Sep 25 2015, 4:32 PM.
Tags
None
Referenced Files
F18831099: D14164.id34228.diff
Sat, Oct 25, 10:56 AM
F18814205: D14164.id.diff
Mon, Oct 20, 10:18 PM
F18810297: D14164.diff
Sun, Oct 19, 8:56 PM
F18806779: D14164.diff
Sat, Oct 18, 9:30 PM
F18634619: D14164.id.diff
Sep 16 2025, 11:06 PM
F18594920: D14164.id.diff
Sep 12 2025, 7:49 PM
F18222254: D14164.id.diff
Aug 19 2025, 8:34 PM
F18099349: D14164.diff
Aug 9 2025, 3:56 AM
Subscribers
None

Details

Summary

Fixes T9328. There's no way to hit these error states by clicking things in the UI that I could find, but if you mash stuff into your URL bar or "Inspect Element..." and then edit the form to be full of garbage you can hit them.

Make them a little more informative and don't send them to the log, since these are pretty much just fancy 404s.

Test Plan

Bashed my fist on the URL bar to hit all these messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make some Herald errors more spider-resistant.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:07 PM
This revision was automatically updated to reflect the committed changes.