Page MenuHomePhabricator

Make some Herald errors more spider-resistant
ClosedPublic

Authored by epriestley on Sep 25 2015, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 2:38 PM
Unknown Object (File)
Fri, Dec 27, 2:38 PM
Unknown Object (File)
Dec 13 2024, 9:13 AM
Unknown Object (File)
Dec 6 2024, 5:14 AM
Unknown Object (File)
Nov 27 2024, 5:20 PM
Unknown Object (File)
Nov 26 2024, 4:43 AM
Unknown Object (File)
Nov 26 2024, 4:42 AM
Unknown Object (File)
Nov 26 2024, 4:16 AM
Subscribers
None

Details

Summary

Fixes T9328. There's no way to hit these error states by clicking things in the UI that I could find, but if you mash stuff into your URL bar or "Inspect Element..." and then edit the form to be full of garbage you can hit them.

Make them a little more informative and don't send them to the log, since these are pretty much just fancy 404s.

Test Plan

Bashed my fist on the URL bar to hit all these messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make some Herald errors more spider-resistant.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:07 PM
This revision was automatically updated to reflect the committed changes.