Page MenuHomePhabricator
Differential D14161

Allow Harbormaster to run commands on Drydock working copies
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 12:16 AM.
Tags
None
Referenced Files
F14051121: D14161.id34231.diff
Thu, Nov 14, 10:22 PM
F14030572: D14161.id.diff
Sat, Nov 9, 4:21 AM
F14030331: D14161.id.diff
Sat, Nov 9, 2:34 AM
F14006272: D14161.id34216.diff
Mon, Oct 28, 4:42 AM
F14001327: D14161.id.diff
Fri, Oct 25, 6:28 AM
F13998780: D14161.id34216.diff
Thu, Oct 24, 11:08 AM
Unknown Object (File)
Oct 7 2024, 3:36 AM
Unknown Object (File)
Oct 7 2024, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rPd735c7adf2d5: Allow Harbormaster to run commands on Drydock working copies
Summary

Ref T9252. This mostly cleans up future and log handling, and edges us closer to being able to do useful work with Harbormaster / Drydock.

Test Plan
  • Added a "Run ls -alh" step to my trivial build plan.
  • Ran it a bunch of times.
  • Worked great.
  • Also did an HTTP plan.

Screen Shot 2015-09-24 at 5.07.36 PM.png (1×2 px, 294 KB)

Screen Shot 2015-09-24 at 5.13.17 PM.png (1×2 px, 784 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34216.Sep 25 2015, 12:16 AM
epriestley retitled this revision from to Allow Harbormaster to run commands on Drydock working copies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9252: Unprototype Drydock (v1).
chad accepted this revision.Sep 25 2015, 5:20 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:20 AM
Closed by commit rPd735c7adf2d5: Allow Harbormaster to run commands on Drydock working copies (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 5:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34231

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/future/HarbormasterExecFuture.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterDrydockCommandBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

Loading...
Phabricator · Built by Phacility