Page MenuHomePhabricator
Differential D14159

Check that the viewer can actually create badges before letting them create badges
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 10:31 PM.
Tags
None
Referenced Files
F18776935: D14159.id34214.diff
Sat, Oct 11, 12:13 AM
F18758908: D14159.diff
Mon, Oct 6, 12:27 AM
F18106440: D14159.id.diff
Aug 10 2025, 10:46 PM
F18095612: D14159.id34214.diff
Aug 8 2025, 12:54 AM
F18052773: D14159.id34213.diff
Aug 4 2025, 3:25 AM
F17977199: D14159.id.diff
Aug 1 2025, 5:39 PM
F17949122: D14159.diff
Jul 31 2025, 10:52 PM
F17738471: D14159.id34213.diff
Jul 20 2025, 11:49 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9467: Badge creation possible without appropriate permission
Commits
Restricted Diffusion Commit
rP381fa611fd8d: Check that the viewer can actually create badges before letting them create…
Summary

Fixes T9467.

Test Plan

Set policy to "no one", got blocked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34213.Sep 24 2015, 10:31 PM
epriestley retitled this revision from to Check that the viewer can actually create badges before letting them create badges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9467: Badge creation possible without appropriate permission.
chad accepted this revision.Sep 24 2015, 10:33 PM
chad edited edge metadata.

:(

This revision is now accepted and ready to land.Sep 24 2015, 10:33 PM
Closed by commit rP381fa611fd8d: Check that the viewer can actually create badges before letting them create… (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 10:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
controller/
3 lines

Diff 34214

View Options

src/applications/badges/controller/PhabricatorBadgesEditController.php

Loading...
Phabricator · Built by Phacility