Page MenuHomePhabricator
Differential D14159

Check that the viewer can actually create badges before letting them create badges
ClosedPublic
Actions

Authored by epriestley on Sep 24 2015, 10:31 PM.
Tags
None
Referenced Files
F15439329: D14159.id34213.diff
Wed, Mar 26, 7:01 AM
F15430491: D14159.id34213.diff
Mon, Mar 24, 7:53 AM
F15376108: D14159.id.diff
Thu, Mar 13, 1:46 AM
Unknown Object (File)
Feb 26 2025, 11:17 AM
Unknown Object (File)
Feb 8 2025, 11:21 PM
Unknown Object (File)
Feb 8 2025, 11:21 PM
Unknown Object (File)
Feb 8 2025, 11:21 PM
Unknown Object (File)
Feb 8 2025, 11:21 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9467: Badge creation possible without appropriate permission
Commits
Restricted Diffusion Commit
rP381fa611fd8d: Check that the viewer can actually create badges before letting them create…
Summary

Fixes T9467.

Test Plan

Set policy to "no one", got blocked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34213.Sep 24 2015, 10:31 PM
epriestley retitled this revision from to Check that the viewer can actually create badges before letting them create badges.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9467: Badge creation possible without appropriate permission.
chad accepted this revision.Sep 24 2015, 10:33 PM
chad edited edge metadata.

:(

This revision is now accepted and ready to land.Sep 24 2015, 10:33 PM
Closed by commit rP381fa611fd8d: Check that the viewer can actually create badges before letting them create… (authored by epriestley, committed by epriestley). · Explain WhySep 24 2015, 10:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
controller/
3 lines

Diff 34214

View Options

src/applications/badges/controller/PhabricatorBadgesEditController.php

Loading...
Phabricator · Built by Phacility