Page MenuHomePhabricator

Convert Drydock lease and resource constants to strings
ClosedPublic

Authored by epriestley on Sep 24 2015, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 8:14 AM
Unknown Object (File)
Tue, Dec 17, 8:03 PM
Unknown Object (File)
Tue, Dec 17, 8:35 AM
Unknown Object (File)
Wed, Dec 11, 10:42 PM
Unknown Object (File)
Fri, Dec 6, 1:09 PM
Unknown Object (File)
Thu, Dec 5, 8:15 PM
Unknown Object (File)
Sat, Nov 30, 6:32 PM
Unknown Object (File)
Sat, Nov 30, 2:36 AM
Subscribers
None

Details

Summary

Ref T9252. Drydock currently uses integer statuses, but there's no reason for this (they don't need to be ordered) and it makes debugging them, working with them, future APIs, etc., more cumbersome.

Switch to string instead.

Also rename STATUS_OPEN to STATUS_ACTIVE and STATUS_CLOSED to STATUS_RELEASED for consistency. This makes resources and leases have more similar states, and gives resource states more accurate names.

Test Plan

Browsed web UI, grepped for changed constants, applied patch, inspected database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert Drydock lease and resource constants to strings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2015, 2:16 PM
This revision was automatically updated to reflect the committed changes.