Page MenuHomePhabricator

Strip some obsolete code out of Drydock
ClosedPublic

Authored by epriestley on Sep 23 2015, 7:34 PM.
Tags
None
Referenced Files
F14055394: D14147.diff
Sat, Nov 16, 11:28 AM
F14043215: D14147.diff
Tue, Nov 12, 8:21 AM
F14028699: D14147.diff
Fri, Nov 8, 3:13 PM
F13987411: D14147.diff
Mon, Oct 21, 9:20 AM
F13974615: D14147.id34187.diff
Oct 18 2024, 6:25 AM
F13970103: D14147.id.diff
Oct 17 2024, 5:44 AM
Unknown Object (File)
Oct 11 2024, 9:25 PM
Unknown Object (File)
Oct 7 2024, 5:55 AM
Subscribers
None

Details

Summary

Ref T9252. This simplifies some Drydock code.

Most of this code relates to the old notion of Drydock being able to enumerate all the tasks it needs to complete in order to acquire a lease. The code has stepped back from this, since it's unnecessary, the queue is more powerful than it used to be, and it would be a lot of work to keep track of.

The ~only thing that should ever wait for leases in modern code is bin/drydock lease, and it's fine for it to just sit there sleeping, so this just does that.

This reduces the granularity of logging, but I'll address that separately in future logging-focused changes.

Test Plan

Used bin/drydock lease to acquire a lease, saw it acquire cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Strip some obsolete code out of Drydock.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 7:45 PM
This revision was automatically updated to reflect the committed changes.