Page MenuHomePhabricator

Use PEAR Text_Figlet to render figlet fonts
ClosedPublic

Authored by epriestley on Sep 13 2015, 6:50 PM.
Tags
None
Referenced Files
F18687581: D14102.id.diff
Fri, Sep 26, 2:54 PM
F18678608: D14102.id34081.diff
Thu, Sep 25, 10:53 PM
F18674055: D14102.diff
Thu, Sep 25, 1:05 PM
F18642212: D14102.diff
Thu, Sep 18, 11:02 PM
F18506477: D14102.id.diff
Sep 5 2025, 1:31 AM
F18499073: D14102.diff
Sep 4 2025, 7:22 PM
F18093433: D14102.id34087.diff
Aug 7 2025, 6:22 PM
F18089018: D14102.id34081.diff
Aug 6 2025, 10:15 AM
Subscribers
None

Details

Summary

Ref T7785. Makes Figlet available without installing the figlet package.

The PEAR Text_Figlet code is really sketchy and includes this API, which is quite marvelous:

function loadFont($filename, $loadgerman = true)

At some point, this should probably be rewritten into a modern style, but it's not trivial since the figlet file format and rendering engine are somewhat complicated. I made some adjustments:

  • Broke the dependency on the PEAR core.
  • Prevented it from doing any wrong HTML escaping.
  • Looked through it for any glaring security or correctness problems.

This code isn't very pretty or modern, but as far as I can tell it's safe and does render Figlet fonts in a reasonable way.

Test Plan

Screen Shot 2015-09-13 at 11.44.43 AM.png (805×1 px, 94 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use PEAR Text_Figlet to render figlet fonts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 13 2015, 7:29 PM
This revision was automatically updated to reflect the committed changes.