Page MenuHomePhabricator

Use PEAR Text_Figlet to render figlet fonts
ClosedPublic

Authored by epriestley on Sep 13 2015, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 1:20 PM
Unknown Object (File)
Wed, Apr 10, 1:50 AM
Unknown Object (File)
Mon, Apr 8, 9:02 AM
Unknown Object (File)
Sat, Apr 6, 4:20 AM
Unknown Object (File)
Mon, Apr 1, 7:48 PM
Unknown Object (File)
Mar 20 2024, 2:24 PM
Unknown Object (File)
Mar 9 2024, 1:45 PM
Unknown Object (File)
Feb 23 2024, 3:09 PM
Subscribers
None

Details

Summary

Ref T7785. Makes Figlet available without installing the figlet package.

The PEAR Text_Figlet code is really sketchy and includes this API, which is quite marvelous:

function loadFont($filename, $loadgerman = true)

At some point, this should probably be rewritten into a modern style, but it's not trivial since the figlet file format and rendering engine are somewhat complicated. I made some adjustments:

  • Broke the dependency on the PEAR core.
  • Prevented it from doing any wrong HTML escaping.
  • Looked through it for any glaring security or correctness problems.

This code isn't very pretty or modern, but as far as I can tell it's safe and does render Figlet fonts in a reasonable way.

Test Plan

Screen Shot 2015-09-13 at 11.44.43 AM.png (805×1 px, 94 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use PEAR Text_Figlet to render figlet fonts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Sep 13 2015, 7:29 PM
This revision was automatically updated to reflect the committed changes.