Page MenuHomePhabricator

Use PHP implementation of Cowsay for cowsay rule
ClosedPublic

Authored by epriestley on Sep 13 2015, 5:26 PM.
Tags
None
Referenced Files
F13084542: D14100.diff
Wed, Apr 24, 11:07 PM
Unknown Object (File)
Wed, Apr 10, 7:29 PM
Unknown Object (File)
Tue, Apr 9, 7:52 PM
Unknown Object (File)
Sun, Apr 7, 1:23 PM
Unknown Object (File)
Fri, Apr 5, 2:23 PM
Unknown Object (File)
Fri, Apr 5, 10:35 AM
Unknown Object (File)
Thu, Apr 4, 2:06 AM
Unknown Object (File)
Sat, Mar 30, 2:30 AM
Subscribers
None

Details

Summary

Ref T7785. Convert the Cowsay Remarkup rule to use a PHP implementation so we don't have to execute an external cowsay binary.

I removed some of the default ".cow" files that come with Cowsay because they:

  • include Perl code which we can not interpret; or
  • are primarily in-jokes or standalone visual puns or artwork rather than usable actors on the grand stage of cowsay; or
  • offended my delicate sensibilities.

Users can add new cows to resources/cows/custom/ if they want to make new cows available.

I have included a majestic original artwork depicting the "Companion Cube" character from Portal.

Test Plan

Screen Shot 2015-09-13 at 9.48.47 AM.png (1×678 px, 78 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use PHP implementation of Cowsay for cowsay rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 13 2015, 7:27 PM
This revision was automatically updated to reflect the committed changes.