Page MenuHomePhabricator

Fix abrupt failure mode for uncloned repositories in Diffusion
ClosedPublic

Authored by epriestley on Sep 3 2015, 10:50 AM.
Tags
None
Referenced Files
F15467543: D14044.id.diff
Thu, Apr 3, 4:01 PM
F15465689: D14044.diff
Wed, Apr 2, 10:02 PM
F15442794: D14044.id33952.diff
Thu, Mar 27, 12:28 AM
F15427864: D14044.id33964.diff
Sun, Mar 23, 4:29 PM
F15402943: D14044.id33952.diff
Tue, Mar 18, 1:12 AM
F15387872: D14044.id33964.diff
Sat, Mar 15, 3:03 AM
F15384321: D14044.diff
Fri, Mar 14, 7:31 PM
F15336797: D14044.diff
Sun, Mar 9, 1:37 AM
Subscribers
None

Details

Summary

Fixes T9080. We try to list alternatives for the current ref (for example, if you're viewing a branch named "master" but there's also a tag named "master", or, in Mercurial, there are several branches named "master") but fail to abruptly if we can't get the list.

It's fine if we can't get the list; just continue. This is common when the repository hasn't cloned yet.

Test Plan

In a local repository with bad credentials, tried to do anything before and after. Before: completely blocked by error; after: things work normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix abrupt failure mode for uncloned repositories in Difufsion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad retitled this revision from Fix abrupt failure mode for uncloned repositories in Difufsion to Fix abrupt failure mode for uncloned repositories in Diffusion.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 3:20 PM
This revision was automatically updated to reflect the committed changes.