Page MenuHomePhabricator

Add calendar icon to project navigation view side bar
Needs RevisionPublic

Authored by peter.schlaile on Aug 22 2015, 3:35 PM.

Details

Reviewers
chad
Group Reviewers
Blessed Reviewers
Summary

This adds a link to the project navigation view side bar, to make project calendars a little bit more
usable for end users.

Test Plan

Side bar rendered correctly, hitting the button triggered the expected advanced search query in calendar application.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 7722
Build 8477: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

peter.schlaile retitled this revision from to Add calendar icon to project navigation view side bar.
peter.schlaile updated this object.
peter.schlaile edited the test plan for this revision. (Show Details)
peter.schlaile set the repository for this revision to rP Phabricator.
peter.schlaile added a project: Calendar.
chad requested changes to this revision.Aug 22 2015, 4:11 PM
chad added a reviewer: chad.
chad added a subscriber: chad.

Please see https://secure.phabricator.com/book/phabcontrib/article/contributing_code/ regarding code contributions to the upstream.

This revision now requires changes to proceed.Aug 22 2015, 4:11 PM

I've read it, but don't really know, how to proceed (or if I'm supposed to proceed in any way):

  • I do know, that calendar is a prototype app
  • It seems to be pretty functional to me, and moving it out of prototype state was a short term goal, if I got it correctly
  • My patches are 1-10 liners, which fix very small issues, so I'm not sure, if they fall into the "very small typo" category or not. Might be language barrier on my side.

Ways I could proceed (I don't have problems with either solution):

  • abandon the revision(s)
  • just leave it as it is, someone will finally reject or accept

For the future:

  • stop submitting even very small changes to prototype apps
  • continue doing so (upstream can always reject)

There are lots of variables at play, mostly here is that we don't know right now how we plan to integrate Calendar and Projects. Any kind of integration is blocked by T5558, which is a large and time consuming problem and one we're not really probably going to look into this year.

Code contribution to the upstream is overall set at a high bar and we're aware of this making things difficult for new contributors. Mostly it's grounded in the fact that any changes that come upstream we inherit all costs on (documenting, maintaining, supporting) so for us to consider changes (especially product changes vs. bug fixes) they need to be well planned beforehand.