Differential D13940

Show all packages with a claim on a file in the table of contents view
ClosedPublic
Actions

Authored by epriestley on Aug 19 2015, 1:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T9218: Should Owners allow multiple packages to own the same file?

Commits

Restricted Diffusion Commit
rP9790f93a835e: Show all packages with a claim on a file in the table of contents view

Summary

Ref T9218. See discussion there for rationale; I think this is the right behavior to pursue.

The screenshot below is pretty ugly. I think it's a lot worse than most real-world cases will be, since you have to sort of opt-in to having crazy levels of overlapping packages, and it's perfectly normal/reasonable for files owned by one package. Owners is powerful enough to let you specify sub-packages with exclusive ownership.

That said, this may be more typical than I hope. I don't think we can reduce the complexity here much for free, but it would might be reasonable to add some view options (e.g.: group by package?, show only packages I own?, show packages as icons with a tooltip?) if it's an issue.

Test Plan

Screen Shot 2015-08-19 at 6.31.17 AM.png (1×1 px, 279 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33648.Aug 19 2015, 1:37 PM

epriestley retitled this revision from to Show all packages with a claim on a file in the table of contents view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9218: Should Owners allow multiple packages to own the same file?.

epriestley added inline comments.Aug 19 2015, 1:38 PM

src/applications/owners/query/PhabricatorOwnersPackageQuery.php
350	This no longer has callsites, but also never should under the T9218 rationale (multiple packages may have claims on a file, and all their claims are valid and real; claim "strength" is only an organizational tool for human users to help when thinking about packages).