Page MenuHomePhabricator
Differential D13865

Load buildables in DiffViewController
ClosedPublic
Actions

Authored by epriestley on Aug 11 2015, 12:26 PM.
Tags
None
Referenced Files
F18855976: D13865.diff
Sat, Nov 1, 7:33 AM
F18837729: D13865.id33494.diff
Oct 27 2025, 7:29 AM
F18824756: D13865.diff
Oct 23 2025, 5:44 PM
F18795998: D13865.id33481.diff
Oct 17 2025, 2:47 AM
F18755832: D13865.id.diff
Oct 5 2025, 7:37 AM
F18498901: D13865.diff
Sep 4 2025, 7:08 PM
F18180260: D13865.id33481.diff
Aug 16 2025, 5:57 AM
F18168059: D13865.diff
Aug 15 2025, 2:02 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9128: manually creating/updating a diff is broken
Commits
Restricted Diffusion Commit
rP53ffaaa889ec: Load buildables in DiffViewController
Summary

Fixes T9128. I missed this when converting other controllers to look in Harbormaster for lint/unit data.

Test Plan

Copy/pasted a diff successfully.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33481.Aug 11 2015, 12:26 PM
epriestley retitled this revision from to Load buildables in DiffViewController.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9128: manually creating/updating a diff is broken.
chad accepted this revision.Aug 11 2015, 1:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 1:36 PM
Closed by commit rP53ffaaa889ec: Load buildables in DiffViewController (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2015, 1:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
11 lines

Diff 33494

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
Phabricator · Built by Phacility