Set a max-height on codeblocks in Conpherence
ClosedPublic
Actions

Authored by chad on Aug 4 2015, 7:44 PM.

Tags

None

Referenced Files

	F14046820: D13790.diff
	Thu, Nov 14, 12:03 AM

	F14023677: D13790.diff
	Thu, Nov 7, 3:35 AM

	F14000621: D13790.diff
	Thu, Oct 24, 11:16 PM

	F13995702: D13790.id33304.diff
	Wed, Oct 23, 2:52 PM

	F13991436: D13790.diff
	Tue, Oct 22, 10:49 AM

	F13990864: D13790.id33305.diff
	Tue, Oct 22, 6:50 AM

	F13980544: D13790.diff
	Oct 19 2024, 11:22 AM

	F13973959: D13790.id.diff
	Oct 18 2024, 3:25 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPf0e7c65d8835: Set a max-height on codeblocks in Conpherence

Summary

Code blocks in Conpherence can be massive and disruptive to a chat-like experience. This caps the height.

Test Plan

Add a ginormous code block to Conpherence, see it hit max-height

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33304.Aug 4 2015, 7:44 PM

chad retitled this revision from to Set a max-height on codeblocks in Conpherence.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2015, 7:44 PM

epriestley accepted this revision.Aug 4 2015, 7:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 4 2015, 7:45 PM

Closed by commit rPf0e7c65d8835: Set a max-height on codeblocks in Conpherence (authored by chad, committed by chad). · Explain WhyAug 4 2015, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

conpherence/

message-pane.css

4 lines

Diff 33305

View Options

resources/celerity/map.php