Page MenuHomePhabricator
Differential D13692

Badges ... on your profile
ClosedPublic
Actions

Authored by chad on Jul 23 2015, 4:05 AM.
Tags
None
Referenced Files
F13415970: D13692.diff
Sun, Jul 7, 8:45 PM
F13403327: D13692.id33092.diff
Fri, Jul 5, 1:56 AM
F13396706: D13692.diff
Thu, Jul 4, 4:26 AM
F13393796: D13692.diff
Wed, Jul 3, 2:31 AM
F13385129: D13692.id.diff
Sun, Jun 30, 9:45 PM
F13385119: D13692.id33098.diff
Sun, Jun 30, 9:39 PM
F13382140: D13692.diff
Sun, Jun 30, 4:00 AM
F13381042: D13692.id33092.diff
Sat, Jun 29, 8:17 PM
View All Files
Subscribers
epriestley
johnny-bit
Korvin
Tokens
"Love" token, awarded by johnny-bit.

Details

Reviewers
epriestley
btrahan
lpriestley
Commits
Restricted Diffusion Commit
rPded654b8e2d5: Badges ... on your profile
Summary

Shows badges on profile if you have them. Check if app is installed, show badges.

Test Plan

Gave myself a liberal selection of badge. Gave notchad one badge. Gave chadtwo absolutely nothing.

pasted_file (588×1 px, 71 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33092.Jul 23 2015, 4:05 AM
chad retitled this revision from to Badges ... on your profile.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan, lpriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 23 2015, 4:05 AM
chad edited the test plan for this revision. (Show Details)Jul 23 2015, 4:06 AM
chad added inline comments.Jul 23 2015, 4:10 AM
src/applications/people/controller/PhabricatorPeopleProfileController.php
209

This seems strange, I can make badges to all users and on public pages they are empty. What's correct here?

chad edited the test plan for this revision. (Show Details)Jul 23 2015, 4:19 AM
chad added a comment.Jul 23 2015, 4:25 AM

I presume I should remove the viewpolicy from badges.

johnny-bit awarded a token.Jul 23 2015, 11:59 AM
johnny-bit added a subscriber: johnny-bit.
johnny-bit removed a subscriber: johnny-bit.
johnny-bit added a subscriber: johnny-bit.
epriestley accepted this revision.Jul 23 2015, 5:27 PM
epriestley edited edge metadata.

Ah, right. Yeah, I think just always giving them getMostOpenPolicy() is probably correct. I don't think we should have secret badges or whatever.

src/applications/people/controller/PhabricatorPeopleProfileController.php
207–210

You can just omit this, CAN_VIEW is the default.

226–228

These should go left one indent level I think?

This revision is now accepted and ready to land.Jul 23 2015, 5:27 PM
epriestley added a comment.Jul 23 2015, 5:29 PM

Did notchad really earn that badge?

Closed by commit rPded654b8e2d5: Badges ... on your profile (authored by chad, committed by chad). · Explain WhyJul 23 2015, 6:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
37 lines
query/
24 lines
storage/
10 lines

Diff 33098

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility