Ref T2015. This makes the working copy blueprints set the owner of leases when they request leases. It also adds some PHID detection to the attribute view of leases and resources, to show handle links when the attribute is likely to contain a PHID.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T2015: Implement Drydock
Viewed pages.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 7806 Build 8644: [Placeholder Plan] Wait for 30 Seconds Build 8643: arc lint + arc unit
Event Timeline
Comment Actions
I'll upstream the rendering side of this if you can get rid of the code duplication between resources/leases. It's fine to just throw it somewhere like DrydockController for now. You may also want to check that phid_get_type() returns a PHID type instead of TYPE_UNKNOWN, but that isn't too important. I think we have no .phid keys in the upstream anymore. Modern handle rendering can just be $viewer->renderHandle($phid).
It would be nice-to-have to pretty-print lists/dictionaries as JSON, too with PhutilJSON. We have one of these in WorkingCopy resources now.
T9493 discusses doing more formalization of this eventually (defining available attributes, giving them real types, etc).