Differential D13635
[harbormaster/core] Implement parameterized build plans Authored by hach-que on Jul 15 2015, 12:09 AM. Tags None Referenced Files
Subscribers
Details
Ref T1049. This implements support for parameterized build plans, and it works correctly with the "Run Build Plan" build step so that things are restarted correctly when you have a hierarchy of build plans. Note that you can only pass in parameters via "Run Build Plan"; there's no support for parameters via Herald or anything of that nature. Tested it locally, about to test it in production.
Diff Detail
Event Timeline
Comment Actions I think we're ready to upstream some flavor of this for T9352, although I think this particular diff is on top of some stuff like D9807 or some other sub-build stuff that I don't want to upstream yet, so I'm just going to steal it and separate the components. I think things will otherwise look mostly similar. One thing I'm probably going to do is put these parameters in their own namespace, like ${build/x.y.z}? Putting a text box on "Run Build Plan" makes perfect sense and I hadn't thought of it (T9352 is only coming at this from the Herald side). We could provide a flag for bin/harbormaster build too. Comment Actions You should just be able to grab this and reset the src/applications/harbormaster/step/HarbormasterRunBuildPlanBuildImplementation.php to make it non-dependant on D9807. That said, I don't know how people would use this without the "Run Build Plan" step, since that's kind of what makes it useful. Comment Actions The parameter bit of this landed in D14222. Some parts that didn't:
Comment Actions Upstream has a different implementation of this now which is sort of partially this diff. Abandoning it because any remaining features would need to be rewritten on top of the new stuff anyway. | ||||||||||||||||||||||||||||||||||||||||||||||||