Paths

Table of Contentst

Differential D13592

Make status icons centered in PHUI object list view
ClosedPublic
Actions

Authored by hach-que on Jul 8 2015, 2:01 AM.

Tags

None

Referenced Files

	F13387830: D13592.id32847.diff
	Mon, Jul 1, 9:07 AM

	F13383975: D13592.diff
	Sun, Jun 30, 1:38 PM

	F13370401: D13592.diff
	Thu, Jun 27, 5:34 PM

	F13368476: D13592.id32849.diff
	Thu, Jun 27, 6:38 AM

	F13367890: D13592.id32848.diff
	Thu, Jun 27, 3:56 AM

	F13362055: D13592.id32849.diff
	Tue, Jun 25, 5:48 PM

	F13346445: D13592.diff
	Fri, Jun 21, 3:34 PM

	F13314846: D13592.id32847.diff
	Wed, Jun 12, 3:28 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8789: Status icons are not centred when they have different widths

Commits

Restricted Diffusion Commit
rP8bf347aa9d29: Make status icons centered in PHUI object list view

Summary

Fixes T8789. This makes status icons centered in the PHUI object list view.

Test Plan

Looked at it.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 32845.Jul 8 2015, 2:01 AM

hach-que retitled this revision from to Make status icons centered in PHUI object list view.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: chad.

hach-que added a task: T8789: Status icons are not centred when they have different widths.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 2:01 AM

Herald added a subscriber: epriestley. · View Herald Transcript

well

I am a CSS noob and probably did this wrong

its not even the right file.

i swear i can hardly breathe right now.

i'll fix it

I'm glad to have provided some entertainment then.

But in all seriousness, I tried search-results.css first, and that didn't seem to apply to pages that had search results on it... given that I was changing how phui-icon-view appears, phui-icon-view.css seemed to be the next most appropriate file to put it in.

Is there a better file that this should be placed in?

phui-object-item-list-view

Put it in the right file

When people see my CSS:

omgsurvivor

chad added inline comments.Jul 8 2015, 2:24 AM

webroot/rsrc/css/phui/phui-object-item-list-view.css
79	I'd move the block up under here since they go together. Other than that, works for me! Appreciate the help.

Move the CSS up

chad accepted this revision.Jul 8 2015, 2:30 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 8 2015, 2:30 AM

Closed by commit rP8bf347aa9d29: Make status icons centered in PHUI object list view (authored by hach-que, committed by hach-que). · Explain WhyJul 8 2015, 2:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

8 lines

Diff 32849

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...