Page MenuHomePhabricator
Differential D13592

Make status icons centered in PHUI object list view
ClosedPublic
Actions

Authored by hach-que on Jul 8 2015, 2:01 AM.
Tags
None
Referenced Files
F14309157: D13592.id32845.diff
Wed, Dec 18, 12:46 AM
Unknown Object (File)
Sat, Dec 14, 1:08 PM
Unknown Object (File)
Thu, Nov 28, 12:08 PM
Unknown Object (File)
Wed, Nov 27, 11:38 PM
Unknown Object (File)
Sat, Nov 23, 12:33 AM
Unknown Object (File)
Wed, Nov 20, 10:39 AM
Unknown Object (File)
Nov 18 2024, 4:01 PM
Unknown Object (File)
Nov 16 2024, 10:23 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8789: Status icons are not centred when they have different widths
Commits
Restricted Diffusion Commit
rP8bf347aa9d29: Make status icons centered in PHUI object list view
Summary

Fixes T8789. This makes status icons centered in the PHUI object list view.

Test Plan

Looked at it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 32845.Jul 8 2015, 2:01 AM
hach-que retitled this revision from to Make status icons centered in PHUI object list view.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: chad.
hach-que added a task: T8789: Status icons are not centred when they have different widths.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 2:01 AM
Herald added a subscriber: epriestley. · View Herald Transcript
chad edited edge metadata.Jul 8 2015, 2:04 AM

well

hach-que added a comment.Jul 8 2015, 2:05 AM

I am a CSS noob and probably did this wrong

chad added a comment.Jul 8 2015, 2:05 AM

its not even the right file.

i swear i can hardly breathe right now.

chad added a comment.Jul 8 2015, 2:06 AM

i'll fix it

hach-que added a comment.Jul 8 2015, 2:09 AM

I'm glad to have provided some entertainment then.

But in all seriousness, I tried search-results.css first, and that didn't seem to apply to pages that had search results on it... given that I was changing how phui-icon-view appears, phui-icon-view.css seemed to be the next most appropriate file to put it in.

Is there a better file that this should be placed in?

chad added a comment.Jul 8 2015, 2:10 AM

phui-object-item-list-view

hach-que updated this revision to Diff 32847.Jul 8 2015, 2:13 AM
hach-que edited edge metadata.

Put it in the right file

hach-que added a comment.Jul 8 2015, 2:19 AM

When people see my CSS:

omgsurvivor

chad added inline comments.Jul 8 2015, 2:24 AM
webroot/rsrc/css/phui/phui-object-item-list-view.css
79

I'd move the block up under here since they go together. Other than that, works for me! Appreciate the help.

hach-que updated this revision to Diff 32848.Jul 8 2015, 2:29 AM

Move the CSS up

hach-que marked an inline comment as done.Jul 8 2015, 2:29 AM
chad accepted this revision.Jul 8 2015, 2:30 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 2:30 AM
Closed by commit rP8bf347aa9d29: Make status icons centered in PHUI object list view (authored by hach-que, committed by hach-que). · Explain WhyJul 8 2015, 2:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
phui/
8 lines

Diff 32849

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility