Tailor the "No Access" message for logged-out users of Spaces
ClosedPublic
Actions

Authored by epriestley on Jul 6 2015, 2:23 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8759: Awkward first experience with Spaces

Commits

Restricted Diffusion Commit
rPdb6b729cf9ac: Tailor the "No Access" message for logged-out users of Spaces

Summary

Fixes T8759.

Test Plan

Screen Shot 2015-07-06 at 7.20.48 AM.png (1×1 px, 157 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32766.Jul 6 2015, 2:23 PM

epriestley retitled this revision from to Tailor the "No Access" message for logged-out users of Spaces.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T8759: Awkward first experience with Spaces.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 6 2015, 2:23 PM

Is it possible to add a 'login' button on the dialog?

This revision is now accepted and ready to land.Jul 6 2015, 2:51 PM

Yes, but I think that will almost never be the correct remedy (approximately 100% of the time, I think the problem here is the administrator not setting 'Visible To' to 'Public' for the default/global space).

Closed by commit rPdb6b729cf9ac: Tailor the "No Access" message for logged-out users of Spaces (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

spaces/

controller/

PhabricatorSpacesNoAccessController.php

45 lines

Diff 32767

View Options

src/applications/spaces/controller/PhabricatorSpacesNoAccessController.php

Tailor the "No Access" message for logged-out users of SpacesClosedPublicActions