Page MenuHomePhabricator

Handle websockets with reverse-proxied phabricator
Needs RevisionPublic

Authored by blaa on Jul 3 2015, 12:52 AM.

Details

Summary

Configuration:
Nginx (SSL + reverse proxy) -> Apache (PHP)
wouldn't work because request, as seen by apache, was never
over HTTPS and http/https setting on client-uri was ignored.

Test Plan

Create configuration with TLS terminated before apache (running phabricator) sees it.
Then try to use websockets/notifications according to documentation at
https://secure.phabricator.com/book/phabricator/article/notifications/

Chromium has a bit better error messages than firefox. Both won't be able to connect
because of security policies.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint SkippedExcuse: Didn't finish after 30 minutes (bad vm)
Unit
Unit Tests OK
Build Status
Buildable 7126
Build 7301: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

blaa retitled this revision from to Handle websockets with reverse-provied phabricator..Jul 3 2015, 12:52 AM
blaa updated this object.
blaa edited the test plan for this revision. (Show Details)
blaa updated this revision to Diff 32718.
epriestley requested changes to this revision.

Set HTTPS in $_SERVER properly, by passing variables or using preamble.php:

https://secure.phabricator.com/book/phabricator/article/configuring_preamble/

This revision now requires changes to proceed.Jul 3 2015, 1:18 AM

If preamble.php is preferred solution then I only suggest to link it here to the `advanced' section:
https://secure.phabricator.com/book/phabricator/article/notifications/
Passing `http' in client-uri suggests it means something and kept me in a loophole for 2 hours.

eadler added a subscriber: eadler.Jul 19 2015, 8:16 PM
dereckson retitled this revision from Handle websockets with reverse-provied phabricator. to Handle websockets with reverse-proxied phabricator..Jul 10 2016, 11:37 PM
dereckson edited edge metadata.
chad retitled this revision from Handle websockets with reverse-proxied phabricator. to Handle websockets with reverse-proxied phabricator.Jul 11 2016, 1:29 AM