Page MenuHomePhabricator
Differential D13526

Special-case text sections with empty headers in emails.
AbandonedPublic
Actions

Authored by klimek on Jul 2 2015, 12:21 PM.
Tags
None
Referenced Files
F15469271: D13526.diff
Fri, Apr 4, 11:20 AM
F15460597: D13526.id32699.diff
Tue, Apr 1, 12:18 AM
F15456481: D13526.id.diff
Sun, Mar 30, 10:01 AM
F15432494: D13526.diff
Mon, Mar 24, 6:20 PM
Unknown Object (File)
Feb 25 2025, 2:28 PM
Unknown Object (File)
Feb 25 2025, 1:29 PM
Unknown Object (File)
Feb 8 2025, 6:27 PM
Unknown Object (File)
Feb 8 2025, 6:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This allows admins to configure a translation that translates some
section headers like REVISION_SUMMARY to an empty string and have the section
blend into the email naturally.

Putting the patch out there so it's clearer what the size of the change is,
and a decision whether to accept this can be made easier.

Test Plan

Configured empty sections, sent email.

Diff Detail

Repository
rP Phabricator
Branch
allow-empty-header-sections
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7114
Build 7280: [Placeholder Plan] Wait for 30 Seconds
Build 7279: arc lint + arc unit

Event Timeline

klimek updated this revision to Diff 32699.Jul 2 2015, 12:21 PM
klimek retitled this revision from to Special-case text sections with empty headers in emails..
klimek updated this object.
klimek edited the test plan for this revision. (Show Details)
klimek added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 2 2015, 12:21 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
klimek abandoned this revision.Jul 3 2015, 4:55 PM

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
view/
30 lines

Diff 32699

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Loading...
Phabricator · Built by Phacility