Don't try to load profile images for projects with no profile image
ClosedPublic
Actions

Authored by epriestley on Jun 29 2015, 9:52 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8631: Straighten out the fetch plan for feed stories

Commits

Restricted Diffusion Commit
rP0ef1d4bc17bb: Don't try to load profile images for projects with no profile image

Summary

Ref T8631. Projects may not have a profile image PHID; don't try to load it if they don't.

Test Plan

Saw WHERE phid IN ('') query stop happening on a local feed story page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32612.Jun 29 2015, 9:52 PM

epriestley retitled this revision from to Don't try to load profile images for projects with no profile image.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8631: Straighten out the fetch plan for feed stories.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2015, 9:52 PM

btrahan accepted this revision.Jun 30 2015, 6:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2015, 6:07 PM

Closed by commit rP0ef1d4bc17bb: Don't try to load profile images for projects with no profile image (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 6:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

18 lines

Diff 32633

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Don't try to load profile images for projects with no profile imageClosedPublicActions