Fix Push Log rendering of query results in redesign
ClosedPublic
Actions

Authored by epriestley on Jun 29 2015, 1:23 PM.

Details

Reviewers

chad

Maniphest Tasks

T8698: Exception when viewing repository push log

Commits

Restricted Diffusion Commit
rPe576ef4bfe2d: Fix Push Log rendering of query results in redesign

Summary

Fixes T8698. This isn't actually a table.

Test Plan

Viewed push log, no more fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32592.Jun 29 2015, 1:23 PM

epriestley retitled this revision from to Fix Push Log rendering of query results in redesign.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8698: Exception when viewing repository push log.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2015, 1:23 PM

chad accepted this revision.Jun 29 2015, 1:50 PM

chad edited edge metadata.

chad added inline comments.

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php
112	need to add `setCollapsed` too to have the table bleed to the edges I think.

This revision is now accepted and ready to land.Jun 29 2015, 1:50 PM

Closed by commit rPe576ef4bfe2d: Fix Push Log rendering of query results in redesign (authored by epriestley, committed by epriestley). · Explain WhyJun 29 2015, 1:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

query/

PhabricatorRepositoryPushLogSearchEngine.php

8 lines

Diff 32594

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Fix Push Log rendering of query results in redesignClosedPublicActions