Page MenuHomePhabricator

Events should offer Spaces as the view policy options
ClosedPublic

Authored by lpriestley on Jun 26 2015, 6:31 PM.

Details

Summary

Ref T8687, Events should offer Spaces as the view policy options

Test Plan

Create event, choose default Space, save, edit, choose different Space, save, new policy should be reflected on Event.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Events should offer Spaces as the view policy options.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley edited edge metadata.

Blerps removal

epriestley edited edge metadata.

In PhabricatorCalendarEventSearchEngine->renderResultList(), you may also need to call setObject() (and maybe setUser()) on the PHUIObjectItemView objects. That will make the Space appear in the list like this, if it's non-default:

Screen Shot 2015-06-27 at 8.46.23 AM.png (128×310 px, 14 KB)

Without this, I'd expect the list view not to show spaces correctly.

This revision is now accepted and ready to land.Jun 27 2015, 3:46 PM
lpriestley edited edge metadata.

Adding spaces info to event list view

This revision was automatically updated to reflect the committed changes.