Page MenuHomePhabricator

MetaMTA - more progress to mail app
ClosedPublic

Authored by btrahan on Jun 23 2015, 7:37 PM.

Details

Summary

Ref T5791. This diff adds a "sensitive" flag to PhabricatorMetaMTAMail, defaults it to true in the constructor, and then sets it to false in teh application transaction editor. Assumption here is that sensitive emails are basically all the emails that don't flow through the application transaction editor.

This diff also gets a basic "mail view" page up and going.

This diff also fixes a bug writing recipient edges; the actor was being included.

This bug also fixes a querying bug; we shouldn't do the automagic join of $viewer is recipient or $viewer is actor if folks are querying for recipients or actors already. The bug manifested itself as having the "inbox" be inbox + outbox.

Test Plan

viewd list of messages. viewed message detail.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

btrahan retitled this revision from to MetaMTA - more progress to mail app.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan updated this revision to Diff 32467.
epriestley edited edge metadata.Jun 23 2015, 7:44 PM
epriestley accepted this revision.

We may eventually want to do the join twice and potentially end up with something like this:

LEFT JOIN edge viewer_recipient ON ...
JOIN edge query_recipient ON ...
(authorPHID = you OR viewer_recipient.dst = you) AND authorPHID in (%Ls) AND query_recipient.dst IN (%Ls)

But that would only matter for performance (more filtering in SQL instead of PHP) which might never really be an issue. I don't anticipate this UI getting enormous amounts of use.

This revision is now accepted and ready to land.Jun 23 2015, 7:44 PM
This revision was automatically updated to reflect the committed changes.