Ref T7950, Refactor Calendar Search, and implement Projects on events
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7950: Support Projects in Calendar
- Commits
- Restricted Diffusion Commit
rPc3efa261f9c1: Refactor Calendar Search, and implement Projects on events
Verify that all queries in Calendar search still work, and that events can now have associated Projects that you can search by in Calendar Search.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php | ||
|---|---|---|
| 31 | Unless these aliases are historic things for backward compatibility, consider just using human-readable aliases like host or creator. The only thing these are useful for is people manually constructing HTTP GET queries like /calendar/?host=epriestley that they type in. So having a human alias like host is a bit helpful since it's more friendly than ?creatorPHIDs=epriestley, but a less-friendly alias like creatorPHID probably isn't too useful. You don't need to repeat the key as an alias, it's automatically recognized. | |
| 85–86 | Now unused? | |
| src/applications/search/engine/PhabricatorApplicationSearchEngine.php | ||
| 296 | Maybe call this shouldShowOrderField()? | |