Page MenuHomePhabricator
Differential D13385

Save authorPHID on Passphrase Credentials to support "Credential Author" object policy
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 2:43 AM.
Tags
None
Referenced Files
F14041622: D13385.id.diff
Mon, Nov 11, 8:05 PM
F13997190: D13385.diff
Thu, Oct 24, 2:55 AM
F13990202: D13385.id32405.diff
Tue, Oct 22, 1:56 AM
F13988484: D13385.id32405.diff
Mon, Oct 21, 3:04 PM
F13986890: D13385.id32416.diff
Mon, Oct 21, 6:10 AM
F13981932: D13385.id32416.diff
Sat, Oct 19, 8:01 PM
F13981850: D13385.id.diff
Sat, Oct 19, 7:28 PM
F13981791: D13385.diff
Sat, Oct 19, 7:04 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies
Commits
Restricted Diffusion Commit
rP85af4b01b962: Save authorPHID on Passphrase Credentials to support "Credential Author"…
Summary

Fixes T5135. Currently, when you create a credential, we default the policies to your PHID. This means we can't have an application-level configurable default because there's no way to select "the actor's PHID" as a policy.

Start tracking the credential author's PHID and add an object policy for it, so there is such a setting.

Then, add policy defaults.

This mostly unblocks T6787. This obsoletes T6860.

Test Plan
  • Created a credential with "Credential Author" policy.
  • Verified I can see/edit it, but other users can not.
  • Changed default policies to something else.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32405.Jun 22 2015, 2:43 AM
epriestley retitled this revision from to Save authorPHID on Passphrase Credentials to support "Credential Author" object policy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2015, 2:43 AM
btrahan accepted this revision.Jun 22 2015, 5:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:27 PM
Closed by commit rP85af4b01b962: Save authorPHID on Passphrase Credentials to support "Credential Author"… (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2015, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
6 lines
applications/
passphrase/
application/
18 lines
capability/
12 lines
16 lines
policyrule/
48 lines
storage/
14 lines

Diff 32416

View Options

resources/sql/autopatches/20150621.phrase.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/application/PhabricatorPassphraseApplication.php

Loading...
View Options

src/applications/passphrase/capability/PassphraseDefaultEditCapability.php

Loading...
View Options

src/applications/passphrase/capability/PassphraseDefaultViewCapability.php

Loading...
View Options

src/applications/passphrase/policyrule/PassphraseCredentialAuthorPolicyRule.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Phabricator · Built by Phacility