Month views with two instances of the same month day number highlight both as 'today'.
ClosedPublic
Actions

Authored by lpriestley on May 27 2015, 11:51 PM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T8334: In month views where there are two days with the same date number (like two 30's), "today" is highlighted on both days.

Commits

Restricted Diffusion Commit
rPa55ed96f984f: Month views with two instances of the same month day number highlight both as…

Summary

Fixes T8334, Month views with two instances of the same month day number highlight both as 'today'.

Test Plan

Open May, only today 27th should be highlighted

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31473.May 27 2015, 11:51 PM

lpriestley retitled this revision from to Month views with two instances of the same month day number highlight both as 'today'..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8334: In month views where there are two days with the same date number (like two 30's), "today" is highlighted on both days..

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 27 2015, 11:51 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 27 2015, 11:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 27 2015, 11:54 PM

Closed by commit rPa55ed96f984f: Month views with two instances of the same month day number highlight both as… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 28 2015, 12:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

calendar/

PHUICalendarMonthView.php

3 lines

Diff 31474

View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Month views with two instances of the same month day number highlight both as 'today'.ClosedPublicActions