Page MenuHomePhabricator

Conpherence - make sure "Join" action in public room works even with no message text
ClosedPublic

Authored by btrahan on May 27 2015, 10:16 PM.

Details

Summary

Fixes T8328. Somewhere along the line we stopped posting to the server with no text. Make sure if the action is join_room that we ping the server even if no text is specified.

Test Plan

tried to send an empty message and failed; nothing happened when I clicked. tried to join a room with an empty message and it worked

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

btrahan retitled this revision from to Conpherence - make sure "Join" action in public room works even with no message text.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 27 2015, 10:16 PM

First diff post arc diff staging was rather beefy... 48M if I am reading this right?

15:13:34 ~/Dropbox/code/phalanx (T8328)
~> arc diff
Linting...
 LINT OKAY  No lint problems.
Running unit tests...
No tests to run.
 PUSH STAGING  Pushing changes to staging area...
Counting objects: 168180, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (48916/48916), done.
Writing objects: 100% (168180/168180), 48.80 MiB | 725.00 KiB/s, done.
Total 168180 (delta 125006), reused 159781 (delta 117722)
To ssh://dweller@secure.phabricator.com/diffusion/STAGING/staging.git
 * [new tag]         46d7d490f39b6b424492e1f205cbe51cdf0b325d -> phabricator/diff/31463
 STAGING PUSHED  Pushed a copy of the changes to tag "phabricator/diff/31463" in the staging area.
Updating commit message...
Created a new Differential revision:
        Revision URI: https://secure.phabricator.com/D13041

Included changes:
  M       resources/celerity/map.php
  M       webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

I figure that's just some git internal cache getting populated, but felt worth raising if unexpected.

Hmm, odd. Did it actually take ~60 seconds to push up?

If you arc diff --only HEAD^ now, is that ~1 second or ~60 seconds?

~1 second

15:16:57 ~/Dropbox/code/phalanx (T8328)
~> arc diff --only HEAD^
 PUSH STAGING  Pushing changes to staging area...
Counting objects: 11, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.44 KiB | 0 bytes/s, done.
Total 11 (delta 8), reused 0 (delta 0)
To ssh://dweller@secure.phabricator.com/diffusion/STAGING/staging.git
 * [new tag]         f9d587db7afbbe5045042422b06ec2c80a47f4ae -> phabricator/diff/31465
 STAGING PUSHED  Pushed a copy of the changes to tag "phabricator/diff/31465" in the staging area.
Created a new Differential diff:
        Diff URI: https://secure.phabricator.com/differential/diff/31465/

Included changes:
  M       resources/celerity/map.php
  M       webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js
This revision was automatically updated to reflect the committed changes.