Page MenuHomePhabricator
Differential D13033

Create button should be a dropdown with public and private options
ClosedPublic
Actions

Authored by lpriestley on May 27 2015, 3:32 AM.
Tags
None
Referenced Files
F15589032: D13033.id31449.diff
Fri, May 9, 10:58 AM
F15550426: D13033.id31451.diff
Sun, Apr 27, 11:42 AM
F15547821: D13033.id31451.diff
Sat, Apr 26, 8:21 PM
F15547820: D13033.id.diff
Sat, Apr 26, 8:21 PM
F15527887: D13033.id31451.diff
Tue, Apr 22, 7:18 AM
F15520959: D13033.id31425.diff
Sun, Apr 20, 9:42 AM
F15497292: D13033.id31451.diff
Sun, Apr 13, 10:15 AM
F15494594: D13033.id31451.diff
Sun, Apr 13, 12:46 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8026: Make event creation modal
Commits
Restricted Diffusion Commit
rP50240eda03e1: Create button should be a dropdown with public and private options
Summary

Ref T8026, Create button should be a dropdown with public and private options

Test Plan

Create both a public and private event. Confirm view policies apply correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31425.May 27 2015, 3:32 AM
lpriestley retitled this revision from to Create button should be a dropdown with public and private options.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8026: Make event creation modal.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 27 2015, 3:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 31449.May 27 2015, 5:40 PM
lpriestley edited edge metadata.

private/public to mode

epriestley accepted this revision.May 27 2015, 5:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 27 2015, 5:47 PM
Closed by commit rP50240eda03e1: Create button should be a dropdown with public and private options (authored by lpriestley, committed by lpriestley). · Explain WhyMay 27 2015, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
14 lines
5 lines
storage/
12 lines
view/
phui/
1 line
12 lines

Diff 31451

View Options

src/applications/calendar/controller/PhabricatorCalendarController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/view/phui/PHUICrumbsView.php

Loading...
View Options

src/view/phui/PHUIListItemView.php

Loading...
Phabricator · Built by Phacility