Page MenuHomePhabricator
Differential D13021

Decouple date and time input classes on AphrontFormDateControl's so that disabling time doesn't disable date.
ClosedPublic
Actions

Authored by lpriestley on May 26 2015, 6:03 PM.
Tags
None
Referenced Files
F14055105: D13021.diff
Sat, Nov 16, 8:18 AM
F14043372: D13021.diff
Tue, Nov 12, 9:48 AM
F14026145: D13021.diff
Thu, Nov 7, 11:49 PM
F13976357: D13021.diff
Oct 18 2024, 1:55 PM
F13976350: D13021.id.diff
Oct 18 2024, 1:51 PM
F13976341: D13021.id31403.diff
Oct 18 2024, 1:50 PM
F13976333: D13021.id31405.diff
Oct 18 2024, 1:48 PM
F13969620: D13021.id.diff
Oct 17 2024, 3:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8319: Selecting "All Day" event hides both date and time inputs
Commits
Restricted Diffusion Commit
rPb292c29dc365: Decouple date and time input classes on AphrontFormDateControl's so that…
Summary

Fixes T8319, Decouple date and time input classes on AphrontFormDateControl's so that disabling time doesn't disable date.

Test Plan

Create new event, make it all day, time input should be hidden, but not date input.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31403.May 26 2015, 6:03 PM
lpriestley retitled this revision from to Decouple date and time input classes on AphrontFormDateControl's so that disabling time doesn't disable date..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8319: Selecting "All Day" event hides both date and time inputs.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 26 2015, 6:03 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 26 2015, 6:22 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 26 2015, 6:22 PM
Closed by commit rPb292c29dc365: Decouple date and time input classes on AphrontFormDateControl's so that… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 26 2015, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
form/
control/
8 lines
webroot/
rsrc/
css/
phui/
10 lines

Diff 31405

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Phabricator · Built by Phacility