Page MenuHomePhabricator
Differential D13010

Convert date control dropdowns to an input for date
ClosedPublic
Actions

Authored by lpriestley on May 25 2015, 8:49 PM.
Tags
None
Referenced Files
F13059924: D13010.id31372.diff
Fri, Apr 19, 5:01 PM
F13059923: D13010.id31371.diff
Fri, Apr 19, 5:01 PM
F13059920: D13010.id31370.diff
Fri, Apr 19, 5:01 PM
F13059899: D13010.id.diff
Fri, Apr 19, 4:59 PM
F13059688: D13010.diff
Fri, Apr 19, 4:41 PM
Unknown Object (File)
Thu, Apr 11, 11:35 PM
Unknown Object (File)
Thu, Apr 11, 8:26 AM
Unknown Object (File)
Sun, Apr 7, 9:03 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8060: Let the date control swap between text and selector modes?
Commits
Restricted Diffusion Commit
rPe8dbdedbd490: Convert date control dropdowns to an input for date
Summary

Ref T8060, Convert date control dropdowns to an input for date

Test Plan

Create new Calendar event, use US time format to enter a date or use datepicker, confirm dates are interpreted correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31370.May 25 2015, 8:49 PM
lpriestley retitled this revision from to Convert date control dropdowns to an input for date.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8060: Let the date control swap between text and selector modes?.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 8:49 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 25 2015, 8:56 PM
epriestley edited edge metadata.

One functional issue inline with the before-8AM events.

src/view/form/control/AphrontFormDateControl.php
194–196

Is this used?

src/view/phui/calendar/PHUICalendarDayView.php
102

We'll never enter this block, now.

This revision is now accepted and ready to land.May 25 2015, 8:56 PM
lpriestley marked 2 inline comments as done.May 25 2015, 9:01 PM
lpriestley added inline comments.
src/view/phui/calendar/PHUICalendarDayView.php
102

Year you're right. I'll address this in a different div.

lpriestley updated this revision to Diff 31371.May 25 2015, 9:01 PM
lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

code review

Closed by commit rPe8dbdedbd490: Convert date control dropdowns to an input for date (authored by lpriestley, committed by lpriestley). · Explain WhyMay 25 2015, 9:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
133 lines
60 lines
phui/
calendar/
5 lines
9 lines
webroot/
rsrc/
js/
core/
63 lines

Diff 31372

View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...
Phabricator · Built by Phacility