Page MenuHomePhabricator

Convert date control dropdowns to an input for date
ClosedPublic

Authored by lpriestley on May 25 2015, 8:49 PM.

Details

Summary

Ref T8060, Convert date control dropdowns to an input for date

Test Plan

Create new Calendar event, use US time format to enter a date or use datepicker, confirm dates are interpreted correctly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lpriestley retitled this revision from to Convert date control dropdowns to an input for date.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

One functional issue inline with the before-8AM events.

src/view/form/control/AphrontFormDateControl.php
194–196

Is this used?

src/view/phui/calendar/PHUICalendarDayView.php
102

We'll never enter this block, now.

This revision is now accepted and ready to land.May 25 2015, 8:56 PM
lpriestley added inline comments.
src/view/phui/calendar/PHUICalendarDayView.php
102

Year you're right. I'll address this in a different div.

lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

code review

This revision was automatically updated to reflect the committed changes.