Differential D13008

Multi-day events should be correctly calculated for new js layout
ClosedPublic
Actions

Authored by lpriestley on May 25 2015, 5:52 PM.

Tags

None

Referenced Files

	F13095810: D13008.id31368.diff
	Thu, Apr 25, 1:10 PM

	Unknown Object (File)
	Tue, Apr 23, 5:29 PM

	Unknown Object (File)
	Tue, Apr 23, 5:14 AM

	Unknown Object (File)
	Fri, Apr 19, 5:02 PM

	Unknown Object (File)
	Mon, Apr 15, 5:30 PM

	Unknown Object (File)
	Fri, Apr 12, 5:20 PM

	Unknown Object (File)
	Thu, Apr 11, 5:48 PM

	Unknown Object (File)
	Mon, Apr 8, 10:32 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8304: New JS layout rules for Calendar events get events which start before 12:00 AM wrong

Commits

Restricted Diffusion Commit
rPe4c991469703: Multi-day events should be correctly calculated for new js layout

Summary

Fixes T8304, Multi-day events should be correctly calculated for new js layout

Test Plan

A day with events starting before midnight of the displayed day should be correctly placed and fitted for day view.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31367.May 25 2015, 5:52 PM

lpriestley retitled this revision from to Multi-day events should be correctly calculated for new js layout.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8304: New JS layout rules for Calendar events get events which start before 12:00 AM wrong.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 5:52 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 25 2015, 5:55 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/infrastructure/time/PhabricatorTime.php
75–79	Might be reasonable to just add this to PhabricatorUser, instead, if you want: $datetime = $viewer->getDateTimeFromEpoch($epoch);

This revision is now accepted and ready to land.May 25 2015, 5:55 PM

lpriestley added inline comments.May 25 2015, 6:15 PM

src/infrastructure/time/PhabricatorTime.php
75–79	Unless you feel strongly about this, it makes more sense in PhabricatorTime, to me, because it's a time conversion, really, and that belongs in a time class of some sort (from where I sit). I, personally, don't mind passing in an extra param.

Closed by commit rPe4c991469703: Multi-day events should be correctly calculated for new js layout (authored by lpriestley, committed by lpriestley). · Explain WhyMay 25 2015, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

time/

PhabricatorTime.php

6 lines

view/

phui/

calendar/

PHUICalendarDayView.php

12 lines

Diff 31368

src/infrastructure/time/PhabricatorTime.php

Loading...

src/view/phui/calendar/PHUICalendarDayView.php

Loading...