Page MenuHomePhabricator

Multi-day events should be correctly calculated for new js layout
ClosedPublic

Authored by lpriestley on May 25 2015, 5:52 PM.
Tags
None
Referenced Files
F17925930: D13008.id.diff
Wed, Jul 30, 12:18 PM
F17907470: D13008.diff
Tue, Jul 29, 1:17 PM
Unknown Object (File)
Jun 29 2025, 3:05 AM
Unknown Object (File)
Jun 29 2025, 2:08 AM
Unknown Object (File)
Jun 20 2025, 12:43 PM
Unknown Object (File)
May 28 2025, 4:13 AM
Unknown Object (File)
May 23 2025, 3:59 AM
Unknown Object (File)
May 9 2025, 7:44 PM
Subscribers

Details

Summary

Fixes T8304, Multi-day events should be correctly calculated for new js layout

Test Plan

A day with events starting before midnight of the displayed day should be correctly placed and fitted for day view.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Multi-day events should be correctly calculated for new js layout.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/infrastructure/time/PhabricatorTime.php
75–79

Might be reasonable to just add this to PhabricatorUser, instead, if you want:

$datetime = $viewer->getDateTimeFromEpoch($epoch);
This revision is now accepted and ready to land.May 25 2015, 5:55 PM
src/infrastructure/time/PhabricatorTime.php
75–79

Unless you feel strongly about this, it makes more sense in PhabricatorTime, to me, because it's a time conversion, really, and that belongs in a time class of some sort (from where I sit). I, personally, don't mind passing in an extra param.

This revision was automatically updated to reflect the committed changes.