Page MenuHomePhabricator
Differential D12969

Possible fix for month view day deadzone
ClosedPublic
Actions

Authored by lpriestley on May 21 2015, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 2:42 AM
Unknown Object (File)
Sat, Apr 13, 8:20 PM
Unknown Object (File)
Tue, Apr 2, 2:35 PM
Unknown Object (File)
Tue, Apr 2, 4:51 AM
Unknown Object (File)
Mon, Apr 1, 7:58 PM
Unknown Object (File)
Sun, Mar 31, 3:46 AM
Unknown Object (File)
Sat, Mar 30, 11:34 AM
Unknown Object (File)
Tue, Mar 26, 2:27 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8193: On month days with a long list of events, there's a deadzone in the month cells where clicking won't open day view.
Commits
Restricted Diffusion Commit
rPd3268aecc226: Possible fix for month view day deadzone
Summary

Ref T8193, Possible fix for month view day deadzone

Test Plan

Open Calendar month view in Chrome, Firefox, or Safari. Verify that days with many events still link to the day views of those days.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31244.May 21 2015, 6:06 PM
lpriestley retitled this revision from to Possible fix for month view day deadzone.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8193: On month days with a long list of events, there's a deadzone in the month cells where clicking won't open day view..
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 21 2015, 6:06 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 31245.May 21 2015, 6:07 PM
lpriestley edited edge metadata.

map

lpriestley updated this revision to Diff 31254.May 21 2015, 10:57 PM

Specificity

chad edited edge metadata.May 21 2015, 11:07 PM

itsawesome

lpriestley updated this revision to Diff 31257.May 21 2015, 11:56 PM
lpriestley edited edge metadata.

surrendering to php

lpriestley updated this revision to Diff 31258.May 22 2015, 12:02 AM

indents

lpriestley updated this revision to Diff 31259.May 22 2015, 12:03 AM

map

lpriestley added a comment.May 22 2015, 12:04 AM

Very disappointed this isn't a css-only fix, but don't see a way around it.

epriestley accepted this revision.May 22 2015, 12:04 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/phui/calendar/PHUICalendarMonthView.php
308–312

I think $count and $max_height are always passed, so you could remove the defaults.

309

Not technically used, since it's always assigned a little later on.

This revision is now accepted and ready to land.May 22 2015, 12:04 AM
lpriestley updated this revision to Diff 31260.May 22 2015, 12:08 AM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

technicalities

Closed by commit rPd3268aecc226: Possible fix for month view day deadzone (authored by lpriestley, committed by lpriestley). · Explain WhyMay 22 2015, 12:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
29 lines
webroot/
rsrc/
css/
phui/
calendar/
6 lines

Diff 31262

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility