Paths

Table of Contentst

Differential D12952

Increase severity of bin/remove destroy warning
ClosedPublic
Actions

Authored by epriestley on May 20 2015, 4:08 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP985eb26c7e32: Increase severity of bin/remove destroy warning

Summary

Make sure we're 100% clear that this is really, truly not recommended.

Also improve the text itself, and show the objects which are being destroyed more clearly.

Test Plan

Removed objects with bin/remove destroy.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31190.May 20 2015, 4:08 PM

epriestley retitled this revision from to Increase severity of bin/remove destroy warning.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2015, 4:08 PM

btrahan accepted this revision.May 20 2015, 8:50 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 20 2015, 8:50 PM

Closed by commit rP985eb26c7e32: Increase severity of bin/remove destroy warning (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2015, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

system/

management/

PhabricatorSystemRemoveDestroyWorkflow.php

76 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

11 lines

Diff 31205

View Options

src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php