Page MenuHomePhabricator
Differential D12925

Calendar list event items should be entirely clickable
ClosedPublic
Actions

Authored by lpriestley on May 19 2015, 4:34 PM.
Tags
None
Referenced Files
F15455574: D12925.diff
Sun, Mar 30, 3:18 AM
F15441726: D12925.id.diff
Wed, Mar 26, 7:36 PM
F15439554: D12925.id31109.diff
Wed, Mar 26, 8:03 AM
F15412469: D12925.id31108.diff
Wed, Mar 19, 1:09 PM
F15387935: D12925.id31106.diff
Sat, Mar 15, 3:07 AM
F15383944: D12925.id31109.diff
Fri, Mar 14, 6:23 PM
F15381403: D12925.diff
Fri, Mar 14, 7:29 AM
F15345609: D12925.diff
Mon, Mar 10, 11:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8248: `PhuiCalendarListView` list items should be entirely clickable.
Commits
Restricted Diffusion Commit
rP27930e8b25e1: Calendar list event items should be entirely clickable
Summary

Ref T8248, Calendar list event items should be entirely clickable

Test Plan

Open month view, verify that adjusting screen correctly adjust widths of event links, and that entire event row links are clickable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31106.May 19 2015, 4:34 PM
lpriestley retitled this revision from to Calendar list event items should be entirely clickable.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T8248: `PhuiCalendarListView` list items should be entirely clickable..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2015, 4:34 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 19 2015, 4:35 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/phui/calendar/PHUICalendarListView.php
78–79

(I don't think this ended up being used, it was just some junk I added.)

This revision is now accepted and ready to land.May 19 2015, 4:35 PM
lpriestley updated this revision to Diff 31108.May 19 2015, 4:57 PM
lpriestley edited edge metadata.

excess class

Closed by commit rP27930e8b25e1: Calendar list event items should be entirely clickable (authored by lpriestley, committed by lpriestley). · Explain WhyMay 19 2015, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
view/
phui/
calendar/
18 lines
webroot/
rsrc/
css/
phui/
calendar/
14 lines
57 lines
1 line

Diff 31109

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-list.css

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar.css

Loading...
Phabricator · Built by Phacility