Page MenuHomePhabricator

Fix Feed Notification Handler for Phabot.
Needs RevisionPublic

Authored by matelich on May 15 2015, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 1, 12:08 PM
Unknown Object (File)
Tue, Oct 1, 12:07 PM
Unknown Object (File)
Tue, Oct 1, 11:54 AM
Unknown Object (File)
Sep 2 2024, 10:04 AM
Unknown Object (File)
Aug 23 2024, 3:02 AM
Unknown Object (File)
Aug 14 2024, 2:32 PM
Unknown Object (File)
Aug 13 2024, 10:02 AM
Unknown Object (File)
Aug 8 2024, 6:24 AM

Details

Summary

Related to T7829. feed.query's after/before parameters seems to be feed-relative, not time-relative. Before a chrono key means later in time (at least by my testing). The notification.channels setting was not being used, all joined channels were receiving messages. If a large number of messages come in at once, the bot may be disconnected for filling RecvQ of the IRC server. Added a sleep of increasing length, similar to behavior of IRC clients and bulk pastes. Add documentation of notifications.verbosity

Test Plan

manual testing

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6019
Build 6039: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

matelich retitled this revision from to Fix Feed Notification Handler for Phabot..
matelich updated this object.
matelich edited the test plan for this revision. (Show Details)
matelich added a reviewer: epriestley.
matelich added a subscriber: eadler.
eadler added a reviewer: eadler.

This seems reasonable to me.

src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
175

eh, ++ inside a sleep statement seems a bit magical

epriestley edited edge metadata.

See T7829.

This revision now requires changes to proceed.May 25 2015, 2:48 PM