Related to T7829. feed.query's after/before parameters seems to be feed-relative, not time-relative. Before a chrono key means later in time (at least by my testing). The notification.channels setting was not being used, all joined channels were receiving messages. If a large number of messages come in at once, the bot may be disconnected for filling RecvQ of the IRC server. Added a sleep of increasing length, similar to behavior of IRC clients and bulk pastes. Add documentation of notifications.verbosity
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable
- Required Signatures
L28 Phacility Individual Contributor License Agreement
manual testing
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6019 Build 6039: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This seems reasonable to me.
src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php | ||
---|---|---|
175 | eh, ++ inside a sleep statement seems a bit magical |