Page MenuHomePhabricator

Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine
ClosedPublic

Authored by btrahan on May 15 2015, 9:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 11:34 PM
Unknown Object (File)
Fri, Jan 17, 12:19 AM
Unknown Object (File)
Thu, Jan 9, 12:29 PM
Unknown Object (File)
Sun, Jan 5, 5:20 PM
Unknown Object (File)
Sun, Dec 29, 11:16 PM
Unknown Object (File)
Sun, Dec 29, 7:17 PM
Unknown Object (File)
Sun, Dec 22, 2:48 AM
Unknown Object (File)
Dec 11 2024, 9:02 PM
Subscribers
Tokens
"Evil Spooky Haunted Tree" token, awarded by epriestley.

Details

Summary

Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase.

I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk.

Test Plan

./bin/remove destroy P1; visit P1 and get a 404

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 15 2015, 9:06 PM
This revision was automatically updated to reflect the committed changes.