Page MenuHomePhabricator
Differential D12846

Calendar tooltips should always show start and end time of events.
ClosedPublic
Actions

Authored by lpriestley on May 14 2015, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 4:33 AM
Unknown Object (File)
Sat, Feb 8, 4:33 AM
Unknown Object (File)
Sat, Feb 8, 4:33 AM
Unknown Object (File)
Sat, Feb 8, 4:33 AM
Unknown Object (File)
Fri, Feb 7, 3:33 PM
Unknown Object (File)
Thu, Feb 6, 9:12 PM
Unknown Object (File)
Sun, Feb 2, 8:05 PM
Unknown Object (File)
Sat, Feb 1, 3:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8191: Month day event tooltips should show start and end time only
Commits
Restricted Diffusion Commit
rP87bf532c4146: Calendar tooltips should always show start and end time of events.
Summary

Closes T8191, Calendar tooltips should always show start and end time of events.

Test Plan

Open month view, hover over, All day events, multi-day all day events, multi-day non-all-day events, and regular events. Tooltips should be "All day", "All day, <start> - <end>", "<start>-<end>", and "<start>-<end>", respectively.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30900.May 14 2015, 7:18 PM
lpriestley retitled this revision from to Calendar tooltips should always show start and end time of events..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8191: Month day event tooltips should show start and end time only.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 14 2015, 7:18 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 14 2015, 7:24 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/phui/calendar/PHUICalendarMonthView.php
304 ↗(On Diff #30900)

debugging code?

This revision is now accepted and ready to land.May 14 2015, 7:24 PM
lpriestley updated this revision to Diff 30901.May 14 2015, 7:34 PM
lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

removing debugging code

Closed by commit rP87bf532c4146: Calendar tooltips should always show start and end time of events. (authored by lpriestley, committed by lpriestley). · Explain WhyMay 14 2015, 7:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
form/
control/
7 lines
phui/
calendar/
34 lines
webroot/
rsrc/
css/
phui/
calendar/
4 lines

Diff 30902

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility