Paths

Table of Contentst

Differential D12839

Remove "status" field from events
AbandonedPublic
Actions

Authored by epriestley on May 14 2015, 4:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 6:40 AM

	Unknown Object (File)
	Mon, Dec 9, 4:02 PM

	Unknown Object (File)
	Mon, Dec 2, 6:27 AM

	Unknown Object (File)
	Nov 28 2024, 11:49 AM

	Unknown Object (File)
	Nov 24 2024, 4:36 AM

	Unknown Object (File)
	Nov 13 2024, 11:43 AM

	Unknown Object (File)
	Nov 11 2024, 7:09 AM

	Unknown Object (File)
	Nov 4 2024, 7:47 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T8183: Remove "Away" and "Sporadic" statuses.

Summary

Ref T8183. See that task for discussion.

For now, events always mark users as "Away".
In the future, we may reintroduce "sporradic" or other more complicated availability states, but they would be properties of the invitee, not of the event itself.
This also removes the long-deprecated user.addstatus and user.removestatus Conduit calls.

Test Plan

Created, edited, viewed events.
Grepped for removed symbols.
Viewed profile calendar.
Viewed Conpherence calendar.
Load Conduit console.

Diff Detail

Repository

Branch

fxform16

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/conpherence/controller/ConpherenceWidgetController.php:222	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 5978
Build 5998: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30883.May 14 2015, 4:30 PM

epriestley retitled this revision from to Remove "status" field from events.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8183: Remove "Away" and "Sporadic" statuses..

Herald added a subscriber: epriestley. · View Herald TranscriptMay 14 2015, 4:30 PM

See D12840, I ^C'd this at a particularly inopportune time.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150514.calendar.status.sql

2 lines

src/

__phutil_library_map__.php

4 lines

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

14 lines

editor/

PhabricatorCalendarEventEditor.php

13 lines

storage/

PhabricatorCalendarEvent.php

46 lines

PhabricatorCalendarEventTransaction.php

23 lines

conpherence/

controller/

ConpherenceWidgetController.php

14 lines

query/

ConpherenceThreadQuery.php

41 lines

people/

conduit/

UserAddStatusConduitAPIMethod.php

UserRemoveStatusConduitAPIMethod.php

Diff 30883

resources/sql/autopatches/20150514.calendar.status.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...

src/applications/people/conduit/UserAddStatusConduitAPIMethod.php

Loading...

src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php

Loading...