Page MenuHomePhabricator

Implement a user profile image cache
ClosedPublic

Authored by epriestley on May 13 2015, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Wed, Apr 24, 4:50 PM
Unknown Object (File)
Sat, Apr 20, 7:35 PM
Unknown Object (File)
Sat, Apr 20, 4:55 PM
Unknown Object (File)
Tue, Apr 16, 4:50 PM
Unknown Object (File)
Sat, Apr 13, 10:02 PM
Subscribers

Details

Summary

Ref T7707. The general form of this can probably be refined somewhat over time as we have more use cases.

I put this cache on the user object itself because we essentially always need this data and it's trivial to invalidate the cache (we can do it implicilty during reads).

Also fix an issue with short, wide images not thumbnailing properly after recent changes.

Test Plan
  • Loaded some pages; saw caches write; saw good pictures.
  • Reloaded; saw cache reads; saw good pictures.
  • Changed profile picture; saw immediate update.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Implement a user profile image cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 13 2015, 5:26 PM
src/applications/files/transform/PhabricatorFileThumbnailTransform.php
51

(This is just making sure that we fit in cache if users upload incredibly long filenames.)

src/applications/files/transform/PhabricatorFileThumbnailTransform.php
51

This revision was automatically updated to reflect the committed changes.