Page MenuHomePhabricator
Differential D12825

Make CSS agnostic to underlying profile image size
ClosedPublic
Actions

Authored by epriestley on May 13 2015, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 1:31 PM
Unknown Object (File)
Thu, Apr 25, 2:53 AM
Unknown Object (File)
Sat, Apr 20, 8:06 PM
Unknown Object (File)
Sat, Apr 13, 10:02 PM
Unknown Object (File)
Sat, Apr 13, 10:02 PM
Unknown Object (File)
Sat, Apr 13, 9:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7707: Implement a read-through cache layer
Commits
Restricted Diffusion Commit
rPb06b3d79b71c: Make CSS agnostic to underlying profile image size
Summary

Ref T7707. My analysis there was a bit confused and this isn't really all that important, but seems cleaner and desirable to be agnostic to the underlying image size.

Test Plan

Tested Safari, Firefox and Chrome with a variety of profile image sizes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30823.May 13 2015, 3:24 PM
epriestley retitled this revision from to Make CSS agnostic to underlying profile image size.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7707: Implement a read-through cache layer.
Herald added a reviewer: chad. · View Herald TranscriptMay 13 2015, 3:24 PM
Herald added a subscriber: epriestley. · View Herald Transcript
btrahan accepted this revision.May 13 2015, 5:23 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 13 2015, 5:23 PM
Closed by commit rPb06b3d79b71c: Make CSS agnostic to underlying profile image size (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
view/
13 lines
webroot/
rsrc/
css/
application/
auth/
19 lines
conpherence/
2 lines
2 lines
phui/
2 lines
2 lines
2 lines

Diff 30835

View Options

src/applications/auth/view/PhabricatorAuthAccountView.php

Loading...
View Options

webroot/rsrc/css/application/auth/auth.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/notification.css

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility